Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull class codes from Athena instead of ccao package in land_nbhd_rate ETL #667

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Pull class codes from Athena instead of ccao package in land_nbhd_rate ETL #667

merged 2 commits into from
Dec 6, 2024

Conversation

jeancochrane
Copy link
Contributor

We're removing the class_dict data variable from the ccao package in ccao-data/ccao#34, so we have to change the reference to it in the ETL script for land_nbhd_rate. We switch the reference to point to the ccao.class_dict table that we added to our data lake in #397.

Warning

For some reason the diff in this PR is reporting that the entire land_nbhd_rate script changed, even though I only adjusted one line. I can't figure out why this is the case (maybe some sort of change in file encoding) so I'm going to just comment on the lines that I changed.

@jeancochrane jeancochrane mentioned this pull request Dec 5, 2024
Merged
@jeancochrane jeancochrane marked this pull request as ready for review December 5, 2024 18:08
@jeancochrane jeancochrane requested a review from a team as a code owner December 5, 2024 18:08
@jeancochrane jeancochrane requested a review from dfsnow December 5, 2024 18:08
dfsnow
dfsnow reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is undoubtedly a line-ending change. Can you use unix2dos or a similar tool to flip the line endings back so we get a true diff? Otherwise, this looks totally fine.

@jeancochrane
Copy link
Contributor Author

Good catch @dfsnow, looks like my editor converted the file from DOS to Unix file format automatically. 303be38 fixes this issue and the diff now looks like what I expected before.

@jeancochrane jeancochrane requested a review from dfsnow December 5, 2024 21:55
dfsnow
dfsnow approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for the line ending fix, looks good to me now.

@jeancochrane jeancochrane merged commit 8615ccc into master Dec 6, 2024
6 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/remove-deprecated-reference-to-ccao-class-dict branch December 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfsnow dfsnow dfsnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeancochrane @dfsnow